-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi agent calibration with pyswarm PSO integration. #41
Multi agent calibration with pyswarm PSO integration. #41
Conversation
02b4648
to
75d7672
Compare
75d7672
to
a7cdc05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not finished here, but some things for interim consideration.
Sorry, @hellkite500, for whatever reason this has slipped through my feed and i've not reviewed it. Im stepping away from the keyboard for an hour or so this morning, but i'll give it a review once im back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small stuff, but there are a few comments that will need to be a few changes before this can get merged.
Remove the test deduplication parts into its own PR. |
a8ec261
to
82d9e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great! Thanks for making the requested changes. There are two minor logical statements that I had questions about, but after we get through them, this should be ready to merge.
f944ba4
to
b7639df
Compare
b7639df
to
5a6060c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
5a6060c
to
dff7de6
Compare
dff7de6
to
3f7d065
Compare
3f7d065
to
5e028a2
Compare
Addressed one major request, and opened an issue for the other. This PR is blocking some others that need review and merged. Feel free to test out and leave feed back on the linked issue or in a new one as needed!
Support for PSO and potentially other multi-agent optimization algorithms.
See changelog for details.
Testing
Todos
Checklist
Testing checklist
Target Environment support